Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatigue calculation updates #122

Merged
merged 6 commits into from
Nov 29, 2024
Merged

Fatigue calculation updates #122

merged 6 commits into from
Nov 29, 2024

Conversation

eneelo
Copy link
Collaborator

@eneelo eneelo commented Dec 15, 2023

Updates

  • More efficient identification of reversals. See docstring of new function qats.signal.find_reversals().

Tasks

  • qats.signal.find_reversals(): alternative and faster identification of reversals.
  • test(s) for qats.signal.find_reversals().

Notes

The PR was intended to also include a new module with new S-N classes, including parameterized S-N model and related functions, however this has been postponed. Relevant tasks would have been:

  • New S-N module with new classes covering both existing functionality and new.
  • Consider deprecating old S-N module (qats.fatigue.sn).
  • Update sphinx documentation.

Note that PR #91 includes a preliminary implementation of a mean load and corrosion dependent S-N curve, which may be migrated or used as inspiration for the postponed updated.

@eneelo eneelo self-assigned this Dec 15, 2023
@eneelo eneelo requested a review from tovop December 15, 2023 13:02
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@eneelo eneelo changed the title Fatigue calculations updates Fatigue calculation updates Dec 15, 2023
@eneelo eneelo marked this pull request as ready for review November 29, 2024 14:30
@eneelo
Copy link
Collaborator Author

eneelo commented Nov 29, 2024

@tovop Small update, ready for review at your convenience.

@tovop
Copy link
Collaborator

tovop commented Nov 29, 2024

Neat improvement, speed ups are very appreciated. Did not cross my mind to use numpy.nonzero.

@eneelo eneelo merged commit 929a655 into master Nov 29, 2024
6 checks passed
@eneelo eneelo deleted the update-fatigue-calc branch November 29, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants