Treewide: Provide specific namespace for Extensions (again) #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in [1], using a separate namespace for Extensions has several advantages. Unfortunately, the dedicated namespace for the PagedListExtensions has been removed during the package name rearrangements and not added back after. This commit adds it back and essentially reverts the namespace scheme to where it was in v10.0.3, like already done for the rest of the code. To indicate this more prominently, the PagedListExtensions.cs class is moved into an "Extensions" subfolder, so the namespace now also matches the folder structure. From the released packages, this affects X.PagedList and X.PagedList.Mvc.Core. [1] 6ae094e ("Treewide: Provide specific namespaces for Extensions") Fixes: dncuug#290
a-gubskiy
approved these changes
Oct 7, 2024
|
Thank you! I will include it in next pre-release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in [1], using a separate namespace for Extensions has several advantages. Unfortunately, the dedicated namespace for the PagedListExtensions has been removed during the package name rearrangements and not added back after.
This commit adds it back and essentially reverts the namespace scheme to where it was in v10.0.3, like already done for the rest of the code.
To indicate this more prominently, the PagedListExtensions.cs class is moved into an "Extensions" subfolder, so the namespace now also matches the folder structure.
From the released packages, this affects X.PagedList and X.PagedList.Mvc.Core.
[1] 6ae094e ("Treewide: Provide specific namespaces for Extensions")
Fixes: #290