Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add autoplay open so you can set up the textureview in oncreate and have... #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kenyee
Copy link

@kenyee kenyee commented May 28, 2014

... it play video automatically

Using this for an intro/welcome screen for an app and wish it had this feature so I added it :-)

@dmytrodanylyk
Copy link
Owner

Please can you make a pull request to dev branch, I will review it later and merge to master.

Also, if possible, rename setAutoPlay method to enableAutoPlay, since set means transfer some parameter in method.

Thanks a lot for contribution!

@kenyee
Copy link
Author

kenyee commented May 28, 2014

all set...put it on the dev branch and renamed it to enableAutoPlay :-)

there's also a bug I tried fixing but was unsuccessful:
If you rotate the phone, it doesn't rescale the crop properly (going from portrait to landscape). I tried adding the updateTextureViewSize call into onSurfaceTextureSizeChanged but then only the first rotation worked...2nd rotation (in portrait) was all stretched again :-P

ken

-----Original Message-----
From: "Dmytro Danylyk" [[email protected]]
Date: 05/28/2014 12:59 PM
To: "dmytrodanylyk/video-crop" [email protected]
CC: "kenyee" [email protected]
Subject: Re: [video-crop] add autoplay open so you can set up the textureview
in oncreate and have... (#2)

Note: Original message sent as attachment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants