[dip-196] Initial onchain network identity DIP draft #200
Conversation
| # Implementations | ||
|
|
||
| N/A | ||
|
|
There was a problem hiding this comment.
recommend an Examples section of how the Diem tech stack would leverage this -- e.g., event emitting, pick up identity, update networking stack... mention other enhancements that you built out to help mitigate attacks (TBF and connection limits)
There was a problem hiding this comment.
This isn't specified in DIP-0. We should update the process even if it's just suggested.
dips/dip-196.md
Outdated
| ## Consuming Network Identity | ||
|
|
||
| Consumers of `NetworkIdentity` may keep track of a list of accounts to watch. The consumers then can watch the event streams of each account's `NetworkIdentity` for updates and update accordingly. | ||
|
|
||
| A consumer may choose to subscribe to all accounts, in which it will watch the `Treasury compliance` account updates and keep track of which accounts to watch accordingly. |
There was a problem hiding this comment.
can you provide the code snippet?
There was a problem hiding this comment.
Currently reworking some of the technical details involving integration with move. Can come up with examples and code snippets once that's done.
gregnazario
force-pushed
the
network-identity
branch
from
ebb4762 to
969005f
Compare
|
@aching Do you have any other comments for this DIP? |
|
Have you had a chance to get to the feedback? I think once addressed, we can commit the draft and make more progress here. |
gregnazario
force-pushed
the
network-identity
branch
from
969005f to
bc91cd5
Compare
gregnazario
force-pushed
the
network-identity
branch
from
bc91cd5 to
3ee3b68
Compare
I've addressed all the feedback but examples / code snippets, as I'm still waiting on changes in the move language to support vec<vec> |
Summary
DIP for Onchain Network Identity