DIP-10 Updates #164
Merged
DIP-10 Updates #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xli
reviewed
Apr 8, 2021
davidiw
previously requested changes
Apr 9, 2021
longbowlu
reviewed
Apr 12, 2021
dahliamalkhi
previously requested changes
Apr 12, 2021
xli
reviewed
Apr 13, 2021
bmwill
reviewed
Apr 13, 2021
xli
reviewed
Apr 13, 2021
xli
approved these changes
Apr 13, 2021
davidiw
reviewed
Apr 14, 2021
xli
approved these changes
Apr 17, 2021
sunmilee
dismissed stale reviews from dahliamalkhi and davidiw
addressed concern
dahliamalkhi
previously requested changes
Apr 19, 2021
sunmilee
dismissed
dahliamalkhi’s stale review
comments addressed, awaiting approval
sunmilee
force-pushed
the
dip10
branch
3 times, most recently
from
9d8c44d to
a31812f
Compare
sunmilee
force-pushed
the
dip10
branch
2 times, most recently
from
2a5b80e to
2a9cf4d
Compare
davidiw
reviewed
Apr 28, 2021
davidiw
approved these changes
Apr 28, 2021
tzakian
pushed a commit
to tzakian/lip
that referenced
this pull request
May 7, 2021
* DIP-10 Updates * Address comments and bech32 update * account identifier * header fix * nits * Dahlia's comments * rename to referenceIDcommandobject * address comment * change header
tzakian
pushed a commit
to tzakian/lip
that referenced
this pull request
May 7, 2021
* DIP-10 Updates * Address comments and bech32 update * account identifier * header fix * nits * Dahlia's comments * rename to referenceIDcommandobject * address comment * change header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing comments in #156. Main changes are: