-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DIP-10 #151
Update DIP-10 #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot to chew on, I'm not convinced I have the best wording or structure in mind, so consider this a conversation. Also what's up with the conflicts on the tests? weird :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this is coming together really well, I think the next push should probably make this ready for more reviews
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after tweaks, ready to approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Let's make an issue for this DIP where folks can continue to give feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making substantial improvements to this DIP!
I wanted to offer some high level comments:
-
I would add a brief introduction to the effect of:
This DIP has two components.
The first part is a 2-level namespace for VASP user addresses, consisting of a username and a VASP name. It includes a method for registering VASPs name(s) on the Diem blockchain.
The second part is a standard framework for initiating a payment transfer to a recipient whose address has already been communicated to an originator (by means left outside the scope of this DIP). The protocol standard arranges for the originator and recipient VASPs to coordinate a transaction referenceID. Other off-chain information exchanges can occur as described in other DIPs (e.g., in DIP-1) and can be embedded within the proposed framework.
-
I would refrain from claims about greater privacy, and any other unsubstantiated privacy statements
-
I am not supportive of the (two part) name Diem ID, since it it not clear it will be the only identity we will have on Diem. I would prefer something more specific, e.g., VAEP (VASP Endpoint) or the like.
-
The user story is cute, but we should emphasize this is only for demonstration purposes, it is NOT part of the proposed standard
-
I wonder whether we should permit more characters in VAEP in order to be compatible with addresses on other blockchains?
* DIP-10 * Rename to Pay Address * Edits * address comments * Addressing comments and reordering * Travel rule and payment metadata * attribute table
@dahliamalkhi, great feedback, routing it to: #156 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also talk about what happens when a reference id is used multiples times. Do we expect the receiver to refund?
* DIP-10 * Rename to Pay Address * Edits * address comments * Addressing comments and reordering * Travel rule and payment metadata * attribute table
* DIP-10 * Rename to Pay Address * Edits * address comments * Addressing comments and reordering * Travel rule and payment metadata * attribute table
* DIP-10 * Rename to Pay Address * Edits * address comments * Addressing comments and reordering * Travel rule and payment metadata * attribute table
Updating DIP-10 to reflect the current PayAddress MVP spec. Changes include: