check that the file is in place: allow unverified ssl #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This patch is for allowing insecure https in the "check that the file is in place" procedure.
This is for example useful in the case where you have a working setup with a http -> https redirection and you want to add a new subdomain xxx.example.com. Since your current certificate doesn't include the new subdomain xxx.example.com then the urlopen fails.
The thing is that let's encrypt doesn't care if the certificate is correct, which is somewhat logical because you are not supposed to have a valid ssl certificate before getting one from let's encrypt. Also the local urlopen check done by acme-tiny is only there for good measure not to disturb let's encrypt if the web-server configuration isn't even correct.
Similar to #157 but with explanation
Cheers,
Pierre