Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-verify flag #116

Closed
wants to merge 2 commits into from

Conversation

andreasscherbaum
Copy link

It is possible that acme_tiny.py runs on a webserver which can't
connect to it's own loadbalancer from the inside. The --no-verify
will skip the local verification step.

It is possible that acme_tiny.py runs on a webserver which can't
connect to it's own loadbalancer from the inside. The --no-verify
will skip the local verification step.
@RonjaPonja
Copy link

See #107

@andreasscherbaum
Copy link
Author

Is this still a "very uncommon case"?

@rspeed
Copy link
Contributor

rspeed commented Apr 7, 2016

I agree with your comment on the other thread about it not being necessary to continue verifying it after the initial setup, but I also agree that this isn't a common enough issue to justify adding a new option. The best course of action would be to remove the verification step entirely and provide an external means to verify your server setup. This would solve your issue while also making acme-tiny easier to audit.

@andreasscherbaum
Copy link
Author

This will remove ~10 lines of code - I like that plan.

@tzeejay
Copy link

tzeejay commented Apr 20, 2016

Just used the fork to sign my cert. Why has this not been added to the master?

@andreasscherbaum
Copy link
Author

@diafygi stated in #107 that this is an uncommon case :-(

@zatricky
Copy link

zatricky commented Apr 25, 2016

Awesome project btw. :)

I don't think the use-case for --no-verify is that uncommon. As mentioned in #122, the number of related issues/PRs is also climbing.

I'm not 100% sure which I'd prefer - but I'm leaning toward adding the flag. The two choices (excluding the choice of simply leaving it alone) are as follows:
a) remove the verify code
b) add the --no-verify flag
Pros of removing the verify code:

  • Less code with similar end-result

Pros of adding the --no-verify flag:

  • Magnitudes-quicker running/debug time with a bad config
  • No unnecessary load on the ACME service

@jreusch
Copy link

jreusch commented May 17, 2016

hello
i'm a (nearly) completely happy user of acme-tiny :)
but i too ran into this problem, "fixed" it myself in the code and wanted to send you a pull request only to see that there are already three open for the exact same feature.
our setup is as follow:
firewall ---> imap/webserver
with the two servers beeing on different machines but in the same subnet.
now when letsencrypt wants to verify the certificate for the imap server, i simply redirect on the firewall the requests to port 80 of the webserver and i'm fine. but not when the webserver itself wants to do the same thing... i don't want to install a webserver on the other machine either (not to speak of an additional firewall in front of it...) so it would be cool to have this --no-verify flag :)

just in case you needed other cases where this problem occures, maybe it isn't that uncommon :)
thx!

@Krenair
Copy link

Krenair commented Aug 2, 2016

In Wikimedia's beta cluster, we have Varnish listening on HTTP and Nginx on HTTPS, with Varnish redirecting these HTTP acme-challenge requests to HTTPS.
But of course, until you have a valid certificate set up, Nginx will be serving a broken self-signed certificate, causing urllib to throw an exception unless you use a hack like https://gerrit.wikimedia.org/r/#/c/247587/3/modules/letsencrypt/files/acme_tiny.py

This would also be helpful in our case.

@frezbo
Copy link

frezbo commented Aug 26, 2016

@andreasscherbaum could you please do PR to my fork, https://github.com/frezbo/acme-tiny

@andreasscherbaum
Copy link
Author

@frezbo Looks like you got it integrated already?

@frezbo
Copy link

frezbo commented Aug 26, 2016

@andreasscherbaum I forgot that I applied your patch previously, it has been a great help, i was getting errors when running script, thanks to you everything is resolved.

@Tronde
Copy link

Tronde commented Sep 3, 2016

Good evening,

I run in exactly the same issue described in #11. It could be resolved only trying the steps xxdesmus mentioned in comment- 162134072.

In my case internal and external DNS resolution is working just fine. I would like to see this PR merged.

Kind regards,
Tronde

@frezbo
Copy link

frezbo commented Sep 4, 2016

@Tronde check my fork of acme-tiny, i have merged the --no-verify option.

@Tronde
Copy link

Tronde commented Sep 4, 2016

@frezbo Thanks for your hint. I just started using your fork as well.

ypid added a commit to ypid/acme-tiny that referenced this pull request Apr 19, 2017
@diafygi
Copy link
Owner

diafygi commented Mar 17, 2018

Added --disable-check option in 4.0.0+

@diafygi diafygi closed this Mar 17, 2018
ypid added a commit to ypid/acme-tiny that referenced this pull request Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants