-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --no-verify flag #116
Add --no-verify flag #116
Conversation
It is possible that acme_tiny.py runs on a webserver which can't connect to it's own loadbalancer from the inside. The --no-verify will skip the local verification step.
See #107 |
Is this still a "very uncommon case"? |
I agree with your comment on the other thread about it not being necessary to continue verifying it after the initial setup, but I also agree that this isn't a common enough issue to justify adding a new option. The best course of action would be to remove the verification step entirely and provide an external means to verify your server setup. This would solve your issue while also making acme-tiny easier to audit. |
This will remove ~10 lines of code - I like that plan. |
Just used the fork to sign my cert. Why has this not been added to the master? |
Awesome project btw. :) I don't think the use-case for --no-verify is that uncommon. As mentioned in #122, the number of related issues/PRs is also climbing. I'm not 100% sure which I'd prefer - but I'm leaning toward adding the flag. The two choices (excluding the choice of simply leaving it alone) are as follows:
Pros of adding the --no-verify flag:
|
hello just in case you needed other cases where this problem occures, maybe it isn't that uncommon :) |
In Wikimedia's beta cluster, we have Varnish listening on HTTP and Nginx on HTTPS, with Varnish redirecting these HTTP acme-challenge requests to HTTPS. This would also be helpful in our case. |
@andreasscherbaum could you please do PR to my fork, https://github.com/frezbo/acme-tiny |
@frezbo Looks like you got it integrated already? |
@andreasscherbaum I forgot that I applied your patch previously, it has been a great help, i was getting errors when running script, thanks to you everything is resolved. |
Good evening, I run in exactly the same issue described in #11. It could be resolved only trying the steps xxdesmus mentioned in comment- 162134072. In my case internal and external DNS resolution is working just fine. I would like to see this PR merged. Kind regards, |
@Tronde check my fork of acme-tiny, i have merged the --no-verify option. |
@frezbo Thanks for your hint. I just started using your fork as well. |
Added |
It is possible that acme_tiny.py runs on a webserver which can't
connect to it's own loadbalancer from the inside. The --no-verify
will skip the local verification step.