Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sns): Add new neuron command SetFollowing #4460

Merged
merged 7 commits into from
Mar 24, 2025
Merged

Conversation

aterga
Copy link
Member

@aterga aterga commented Mar 21, 2025

This PR adds a new neuron management command, SetFollowing. This command is not currently implemented and cannot be used; we just introduce the required API level changes.

@github-actions github-actions bot added the feat label Mar 21, 2025
@aterga aterga marked this pull request as ready for review March 21, 2025 15:37
@aterga aterga requested a review from a team as a code owner March 21, 2025 15:37
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).

To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:

  1. Done.

  2. No canister behavior changes.

@aterga aterga enabled auto-merge March 21, 2025 16:34
@aterga aterga added CI_OVERRIDE_BUF_BREAKING Skip buf-breaking (protobuf) check (explain in PR description why) CI_OVERRIDE_DIDC_CHECK Skips the backwards compatibility didc check (explain in PR description why) labels Mar 21, 2025
@aterga
Copy link
Member Author

aterga commented Mar 21, 2025

The PR breaks the API by moving from followees : vec NeuronId; to followees : vec Followee;.

  • Why I want this: This is to accommodate for more (optional) fields, e.g., the neuron's alias. The requirement wasn't clear to me a few days ago, but now it's clear that the frontends would benefit from this API.
  • This is safe because we're breaking the API that cannot be used for now (so the internal types are not used and the frontends were not yet adjusted to use the external types).

@aterga aterga requested review from a team as code owners March 24, 2025 21:07
@aterga aterga changed the title feat(sns): Add new neuron command SetFollowingForTopics feat(sns): Add new neuron command SetFollowing Mar 24, 2025
@aterga aterga added this pull request to the merge queue Mar 24, 2025
Merged via the queue into master with commit 15b655f Mar 24, 2025
22 checks passed
@aterga aterga deleted the arshavir/NNS1-3675 branch March 24, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI_OVERRIDE_BUF_BREAKING Skip buf-breaking (protobuf) check (explain in PR description why) CI_OVERRIDE_DIDC_CHECK Skips the backwards compatibility didc check (explain in PR description why) @consensus @execution feat @ic-message-routing-owners @nns-team @pocket-ic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants