chore: [NODE-1577] add a file size check for ic-os upgrade images #4453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-birkner
force-pushed
the
rjb/add-size-test
branch
7 times, most recently
from
738e15d to
8bdbdd8
Compare
r-birkner
commented
Mar 21, 2025
r-birkner
changed the title
frankdavid
reviewed
Mar 21, 2025
frankdavid
reviewed
Mar 21, 2025
frankdavid
reviewed
Mar 21, 2025
frankdavid
reviewed
Mar 21, 2025
frankdavid
approved these changes
Mar 21, 2025
r-birkner
force-pushed
the
rjb/add-size-test
branch
5 times, most recently
from
c2ef878 to
1aac7bd
Compare
basvandijk
reviewed
Mar 24, 2025
r-birkner
force-pushed
the
rjb/add-size-test
branch
from
31d6f37 to
75c5c85
Compare
basvandijk
reviewed
Mar 24, 2025
r-birkner
force-pushed
the
rjb/add-size-test
branch
from
75c5c85 to
dd98a22
Compare
r-birkner
force-pushed
the
rjb/add-size-test
branch
2 times, most recently
from
3ded1ee to
30e9494
Compare
basvandijk
approved these changes
Mar 24, 2025
r-birkner
force-pushed
the
rjb/add-size-test
branch
from
30e9494 to
5824b96
Compare
daniel-wong-dfinity-org
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test to monitor the size of compressed ICOS images, ensuring that any significant increase is intentional. If the artifact size exceeds a configured limit, the test will fail, prompting a review of the change. If the increase is expected, the limit can be adjusted accordingly. This check applies only to production variants of the ICOS images.