feat(IDX): upload artifacts with bazel run #4448
Draft
+147
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmattia
commented
Mar 20, 2025
nmattia
commented
Mar 20, 2025
nmattia
force-pushed
the
nm-run-upload
branch
3 times, most recently
from
2c0b4f5 to
99e8cc6
Compare
This moves the artifact upload out of the bazel build itself. This means the upload can be run with `bazel run`, reducing the need for injecting credentials into the build and allowing the upload to be re-run whenever necessary (and e.g. not cached by Bazel), also making the upload step a bit more declarative.
basvandijk
approved these changes
Mar 20, 2025
marko-k0
reviewed
Mar 21, 2025
| # Query for targets tagged with 'upload' which are expected to be run | ||
| # on release build (for uploading artifacts) | ||
| upload_targets=$(bazel query "attr(tags, '\\bupload\\b', //...)") | ||
| if [[ $RELEASE_BUILD == true ]]; then |
There was a problem hiding this comment.
yep, definitely. What makes you pause?
There was a problem hiding this comment.
ah, I see what you mean. No it's not. Thanks! (copied it out of the upload script and didn't adapt)
There was a problem hiding this comment.
Actually I now realize that I can't just move the upload out of the main.sh script. Will need to change a couple things for, so for now will move it back to main.sh. Good catch!
marko-k0
reviewed
Mar 21, 2025
Co-authored-by: Marko Kosmerl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the artifact upload out of the bazel build itself. This means the upload can be run with
bazel run, reducing the need for injecting credentials into the build and allowing the upload to be re-run whenever necessary (and e.g. not cached by Bazel), also making the upload step a bit more declarative.