test(ICRC_Rosetta): FI-1699: Bump the retry limit #4446
Conversation
|
The test has been flaky on CI, and it was also reproducible in the devenv container e.g., here. After bumping the retry limit, in this test run with 1000 repetitions, no failures were due to this issue. |
| @@ -179,7 +179,8 @@ impl RosettaClient { | |||
| let request = SearchTransactionsRequest::builder(network_identifier.clone()) | |||
| .with_transaction_identifier(submit_response.transaction_identifier.clone()) | |||
| .build(); | |||
| while tries < 10 { | |||
| const MAX_RETRIES: u64 = 30; | |||
There was a problem hiding this comment.
Note that this is a change in the production code, not test code. Another option could be to allow specifying this value as a configuration option?
There was a problem hiding this comment.
Is there a downside to increasing the limit in prod?
There was a problem hiding this comment.
Good question!
Another thought I had was to split the functionality of make_submit_and_wait_for_transaction into make_submit and wait_for_transaction methods, and then the caller could decide how often and for how long they would call wait_for_transaction if the transaction doesn't get added to the blockchain. The methods called internally in make_submit_and_wait_for_transaction seem to all be public, so a caller could already now mimic the functionality - we could also consider doing that in the tests.
Maybe @fsodre has some views?
Bump the retry limit from 10s to 30s while waiting for transactions to be added to the blockchain.