feat: [EXC-1955] Add canister snapshot metadata fields to types #4431
+218
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-weigelt
changed the title
github-actions
bot
added
@execution
@ic-interface-owners
@ic-message-routing-owners
labels
michael-weigelt
commented
Mar 19, 2025
rs/protobuf/def/state/canister_snapshot_bits/v1/canister_snapshot_bits.proto
Show resolved
Hide resolved
michael-weigelt
commented
Mar 25, 2025
michael-weigelt
added
the
CI_ALL_BAZEL_TARGETS
|
Closing and reopening to force CI rerun |
schneiderstefan
approved these changes
Mar 26, 2025
dsarlis
reviewed
Mar 26, 2025
Co-authored-by: Stefan Schneider <[email protected]>
dsarlis
approved these changes
Mar 27, 2025
|
@michael-weigelt What is the reason we only keep LowWasmMemoryHookStatus instead of the whole TaskQueue when taking snapshots? |
|
@dragoljub-duric IIUC, the task_queue could contain other messages that we don't want to persist in a snapshot. This way, we only keep what we need (based on the hook status we can restore a hook message if necessary). |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the existing snapshot types with new fields needed for the canister snapshot metadata endpoints.