fix: Exclude unverified checkpoint marker when listing all paths for marking ReadOnly #4429
+37
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShuoWangNSL
changed the title
ShuoWangNSL
force-pushed
the
shuo/exclude_unverified_marker_when_listing
branch
2 times, most recently
from
1a882e0 to
4cd973e
Compare
ShuoWangNSL
force-pushed
the
shuo/exclude_unverified_marker_when_listing
branch
from
4cd973e to
0258f12
Compare
ShuoWangNSL
commented
Mar 19, 2025
pakhomov-dfinity
approved these changes
Mar 20, 2025
|
Run a production test of installing 100k canisters. The 40ms additional time is OK as it is not significant compared to others and the whole function happens asynchronously during checkpointing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the test failure of
can_state_sync_into_existing_checkpoint, where the main thread removes the unverified checkpoint marker but the state sync thread tries to mark it as readonly.It excludes the marker from the list of paths, since another thread might also be validating the checkpoint and may have already deleted the marker. Marking the unverified marker as read-only is unnecessary for this function's purpose and may cause an error.