test(sns): Move SNS integration tests to SNS Governance API types #4428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aterga
commented
Mar 19, 2025
| @@ -303,6 +304,32 @@ impl SnsInitializationFlowTestSetup { | |||
| } | |||
| } | |||
|
|
|||
| // TODO: Reuse this function from ic_sns_test_utils::state_test_helpers once that crate is ported | |||
| // TODO: to use `ic_sns_governance_api` (rather than `ic_sns_governance`). | |||
| fn sns_governance_list_neurons( | |||
There was a problem hiding this comment.
The idea is to reuse as much functionality as possible from ic_nervous_system_agent. This is here temporarily.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
This PR adds a new crate under `rs/sns/governance/api_helpers`. This crate is dedicated to helper functions defined on top of the SNS Governance API, which are extensively used by SNS integration tests. | [Next PR](#4428) > --------- Co-authored-by: IDX GitHub Automation <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the tests run via
bazel test //rs/sns/integration_tests/...to theic_sns_governance_apitypes (currently, the internalic_sns_governancetypes are used in those tests, for historical reasons).While the explicit
ic_sns_governance_apidependency is removed, it is still used implicitly via.into()for converting to and from inner types that are still being used by these tests from external crates (e.g., rs/nns/test_utils`). This support a gradual approach in which we don't need to port multiple crates at once.< Previous PR |