Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial version of the spec. #33
Initial version of the spec. #33
Changes from 2 commits
f1d171e
f4a5a71
78572b7
c5ca610
92c1164
cf571d9
0f0034e
9439efb
9eb8f46
6776bfb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given we had an item in this repo that dealt with where
devcontainer.json
can be found, I'd suggest including that logic here. e.g.,@chrmarti @edgonmsft is the above the right order?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like we use a combination of
docker-compose
andDocker Compose
in this text. Could we consistently choose one? Or is there a specific pattern when we should use one vs the other?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get what you mean and agree it's confusing. In my head Docker Compose is when we talk about the way it works, the configuration and specification and
docker-compose
is the actual application used. Like on line 47.But if its confusing I can merge and just pick one.