Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate env var sourcing for codespaces #481

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

eljog
Copy link
Member

@eljog eljog commented Mar 9, 2023

Codespaces already has the same mechanism built-in for sourcing secrets for login shells, from env-secrets file.
Removing the redundant and codespaces specific code from sshd feature.

@eljog eljog requested a review from a team as a code owner March 9, 2023 20:23
dmgardiner25
dmgardiner25 previously approved these changes Mar 9, 2023
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@eljog eljog merged commit 1449f41 into main Mar 10, 2023
@eljog eljog deleted the eljog/remove-codespaces-var-sourcing branch March 10, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants