Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add navProps to SideBar component #458

Merged
merged 1 commit into from
Dec 14, 2021
Merged

fix: Add navProps to SideBar component #458

merged 1 commit into from
Dec 14, 2021

Conversation

dequejosie
Copy link
Contributor

@dequejosie dequejosie commented Dec 14, 2021

Closes: #327

@dequejosie dequejosie merged commit 4607c12 into develop Dec 14, 2021
@dequejosie dequejosie deleted the add-nav-props branch December 14, 2021 22:53
stephenmathieson added a commit that referenced this pull request Jan 5, 2022
* develop:
  build: Setup Amplify PR deployment previews (#495)
  feat(react,styles): Adds pagination component (#485)
  fix(react): ensure that icons are set with viewbox and standard height/width values (#487)
  fix: Move Error bottom margin to its parent components (#450)
  fix(react): add missing viewbox attribute to svg icons (#486)
  feat: replaced the panel implementation with a new one to match our pattern library (#469)
  chore: Delete Netlify config (#476)
  fix(styles): ensure that scrollbars match light/dark scheme (#474)
  fix(react): fix incorrect icons being displayed in Safari (#473)
  fix: Change focus outline colors for main (#466)
  fix: Implement dark theme to Tag (#467)
  fix: Tag value font weight should be medium (#468)
  fix(styles): update the link color to be set correctly for light/dark modes (#465)
  fix: Implement dark theme to Table (#463)
  fix: Update description list component according to design (#462)
  fix: Add aria label to disabled IconButton (#461)
  fix(react): update loader to address issues with being announced in JAWS (#459)
  fix: Add navProps to SideBar component (#458)
  fix(styles): set close button for toast to have a minimum height of 24px (#457)
stephenmathieson added a commit that referenced this pull request Jan 5, 2022
* develop:
  build: Setup Amplify PR deployment previews (#495)
  feat(react,styles): Adds pagination component (#485)
  fix(react): ensure that icons are set with viewbox and standard height/width values (#487)
  fix: Move Error bottom margin to its parent components (#450)
  fix(react): add missing viewbox attribute to svg icons (#486)
  feat: replaced the panel implementation with a new one to match our pattern library (#469)
  chore: Delete Netlify config (#476)
  fix(styles): ensure that scrollbars match light/dark scheme (#474)
  fix(react): fix incorrect icons being displayed in Safari (#473)
  fix: Change focus outline colors for main (#466)
  fix: Implement dark theme to Tag (#467)
  fix: Tag value font weight should be medium (#468)
  fix(styles): update the link color to be set correctly for light/dark modes (#465)
  fix: Implement dark theme to Table (#463)
  fix: Update description list component according to design (#462)
  fix: Add aria label to disabled IconButton (#461)
  fix(react): update loader to address issues with being announced in JAWS (#459)
  fix: Add navProps to SideBar component (#458)
  fix(styles): set close button for toast to have a minimum height of 24px (#457)
  feat(react): add onChange prop to tabs when the active tab changes (#453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Sidebar> component's <nav> should have an accessible name
2 participants