Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): ensure that header-text-color-dark is not used by other components #360

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

scurker
Copy link
Member

@scurker scurker commented Oct 5, 2021

--header-text-color-dark was used by several other components (and in the extension) so that when implementing themes, it was causing some significant issues between the different modes. Trying to clean it up a bit so its not reset according to themes to not break compatibility.

@scurker scurker merged commit 1066cf1 into develop Oct 5, 2021
@scurker scurker deleted the header-text-color-dark branch October 5, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants