Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: ExpandCollapse component should use font-family: roboto #888

Closed
dequejenn opened this issue Feb 13, 2023 · 6 comments · Fixed by #895
Closed

Bug: ExpandCollapse component should use font-family: roboto #888

dequejenn opened this issue Feb 13, 2023 · 6 comments · Fixed by #895
Labels
bug Something isn't working

Comments

@dequejenn
Copy link

Steps to reproduce

https://cauldron.dequelabs.com/components/ExpandCollapsePanel is not forcing all font within it to be font-family: roboto

Expected Behavior

All font should be font-family: roboto

Actual Behavior

It is not the right font

Version

I dunno

What browsers are you experiencing the problem on?

No response

Relevant log output

No response

Anything else we should know?

Additional information

@Bracciata
Copy link
Contributor

Hope you don't mind me tackling this one! I was able to replicate and implement a fix in the mentioned PR.

@scurker
Copy link
Member

scurker commented Feb 21, 2023

This is related to not having a css reset (#18) since the button is inheriting whatever is set via the user agent stylesheet.

@bobbyomari
Copy link
Contributor

Let's add font-weight: 500 (variable) to all buttons as well so it does not inherit from the browser.

@Bracciata
Copy link
Contributor

Correct me if I am wrong but wouldn't adding a CSS reset make the buttons also inherit font-weight: 500 @bobbyomari ?

@scurker
Copy link
Member

scurker commented Feb 21, 2023

We want to add a css reset eventually, but for now we're going to override the font-family/weight for just buttons.

@Bracciata
Copy link
Contributor

Makes sense! Added it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants