fix(react): add missing viewbox attribute to svg icons #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmathieson
approved these changes
Dec 28, 2021
stephenmathieson
added a commit
that referenced
this pull request
Jan 5, 2022
* develop: build: Setup Amplify PR deployment previews (#495) feat(react,styles): Adds pagination component (#485) fix(react): ensure that icons are set with viewbox and standard height/width values (#487) fix: Move Error bottom margin to its parent components (#450) fix(react): add missing viewbox attribute to svg icons (#486) feat: replaced the panel implementation with a new one to match our pattern library (#469) chore: Delete Netlify config (#476) fix(styles): ensure that scrollbars match light/dark scheme (#474) fix(react): fix incorrect icons being displayed in Safari (#473) fix: Change focus outline colors for main (#466) fix: Implement dark theme to Tag (#467) fix: Tag value font weight should be medium (#468) fix(styles): update the link color to be set correctly for light/dark modes (#465)
stephenmathieson
added a commit
that referenced
this pull request
Jan 5, 2022
* develop: build: Setup Amplify PR deployment previews (#495) feat(react,styles): Adds pagination component (#485) fix(react): ensure that icons are set with viewbox and standard height/width values (#487) fix: Move Error bottom margin to its parent components (#450) fix(react): add missing viewbox attribute to svg icons (#486) feat: replaced the panel implementation with a new one to match our pattern library (#469) chore: Delete Netlify config (#476)
stephenmathieson
added a commit
that referenced
this pull request
Jan 5, 2022
* develop: build: Setup Amplify PR deployment previews (#495) feat(react,styles): Adds pagination component (#485) fix(react): ensure that icons are set with viewbox and standard height/width values (#487) fix: Move Error bottom margin to its parent components (#450) fix(react): add missing viewbox attribute to svg icons (#486) feat: replaced the panel implementation with a new one to match our pattern library (#469) chore: Delete Netlify config (#476) fix(styles): ensure that scrollbars match light/dark scheme (#474) fix(react): fix incorrect icons being displayed in Safari (#473) fix: Change focus outline colors for main (#466) fix: Implement dark theme to Tag (#467) fix: Tag value font weight should be medium (#468) fix(styles): update the link color to be set correctly for light/dark modes (#465) fix: Implement dark theme to Table (#463) fix: Update description list component according to design (#462) fix: Add aria label to disabled IconButton (#461) fix(react): update loader to address issues with being announced in JAWS (#459) fix: Add navProps to SideBar component (#458) fix(styles): set close button for toast to have a minimum height of 24px (#457)
stephenmathieson
added a commit
that referenced
this pull request
Jan 5, 2022
* develop: build: Setup Amplify PR deployment previews (#495) feat(react,styles): Adds pagination component (#485) fix(react): ensure that icons are set with viewbox and standard height/width values (#487) fix: Move Error bottom margin to its parent components (#450) fix(react): add missing viewbox attribute to svg icons (#486) feat: replaced the panel implementation with a new one to match our pattern library (#469) chore: Delete Netlify config (#476) fix(styles): ensure that scrollbars match light/dark scheme (#474) fix(react): fix incorrect icons being displayed in Safari (#473) fix: Change focus outline colors for main (#466) fix: Implement dark theme to Tag (#467) fix: Tag value font weight should be medium (#468) fix(styles): update the link color to be set correctly for light/dark modes (#465) fix: Implement dark theme to Table (#463) fix: Update description list component according to design (#462) fix: Add aria label to disabled IconButton (#461) fix(react): update loader to address issues with being announced in JAWS (#459) fix: Add navProps to SideBar component (#458) fix(styles): set close button for toast to have a minimum height of 24px (#457) feat(react): add onChange prop to tabs when the active tab changes (#453)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icons were appearing janky inside of an icon button because they're getting resized, but a
viewboxattribute was not being set, so only the svg container and not the full svg was getting resized.