fix(react): makes dialogRef an optional prop for Dialog (#100)

dequelabs · Oct 26, 2020 · b19190b · b19190b
1 parent 35dd790
commit b19190b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/packages/react/src/components/Dialog/index.tsx b/packages/react/src/components/Dialog/index.tsx
@@ -14,7 +14,7 @@ export interface DialogProps extends React.HTMLAttributes<HTMLDivElement> {
   children: React.ReactNode;
   className?: string;
   show?: boolean;
-  dialogRef: React.Ref<HTMLDivElement>;
+  dialogRef?: React.Ref<HTMLDivElement>;
   onClose: () => void;
   forceAction?: boolean;
   heading:
@@ -37,8 +37,7 @@ export default class Dialog extends React.Component<DialogProps, DialogState> {
   static defaultProps = {
     onClose: noop,
     forceAction: false,
-    closeButtonText: 'Close',
-    dialogRef: noop
+    closeButtonText: 'Close'
   };
 
   static propTypes = {
@@ -135,6 +134,9 @@ export default class Dialog extends React.Component<DialogProps, DialogState> {
             })}
             ref={el => {
               this.element = el;
+              if (!dialogRef) {
+                return;
+              }
               setRef(dialogRef, el);
             }}
             {...other}

diff --git a/packages/react/src/utils/setRef.ts b/packages/react/src/utils/setRef.ts
@@ -5,6 +5,7 @@ export default function setRef<T>(ref: React.Ref<T>, element: T) {
   if (typeof ref === 'function') {
     ref(element);
   } else {
+    // eslint-disable-next-line
     // @ts-ignore
     // we need to overwrite the existing value in some special cases
     ref.current = element;