fix(styles): Updates textfield labels/margins

dequelabs · Nov 6, 2020 · 9064f27 · 9064f27
1 parent 3eedbb9
commit 9064f27
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 10 deletions.
diff --git a/docs/index.html b/docs/index.html
@@ -4,10 +4,6 @@
     <meta charset="utf-8" />
     <meta name="viewport" content="width=device-width" />
     <script src="https://use.fontawesome.com/99d8f1b106.js"></script>
-    <link
-      href="https://fonts.googleapis.com/css2?family=Roboto"
-      rel="stylesheet"
-    />
     <title>Deque Cauldron React</title>
   </head>
   <body>

diff --git a/docs/index.js b/docs/index.js
@@ -18,6 +18,7 @@ import {
   Icon
 } from '@deque/cauldron-react';
 import logo from './assets/img/logo.svg';
+import 'fontsource-roboto';
 
 // styles
 import '../packages/styles';

diff --git a/docs/patterns/components/TextField/index.css b/docs/patterns/components/TextField/index.css
@@ -1,7 +1,3 @@
 .TextField button {
   margin: 0;
 }
-
-.TextField .Field {
-  margin-bottom: 0;
-}
diff --git a/package.json b/package.json
@@ -34,6 +34,7 @@
     "eslint-plugin-jsx-a11y": "^6.1.1",
     "eslint-plugin-react": "^7.5.1",
     "file-loader": "^1.1.5",
+    "fontsource-roboto": "^3.0.3",
     "html-webpack-plugin": "^3.2.0",
     "husky": "^1.0.0-rc.14",
     "jest-axe": "^3.1.1",

diff --git a/packages/styles/forms.css b/packages/styles/forms.css
@@ -80,7 +80,6 @@ textarea.Field--has-error:focus,
   display: block;
   position: relative;
   box-sizing: border-box;
-  margin-bottom: var(--space-large);
 }
 
 .Field.is--flex-row {
@@ -108,7 +107,7 @@ textarea.Field--has-error:focus,
   text-align: left;
   color: #333333;
   font-size: var(--text-size-smaller);
-  font-weight: var(--font-weight-light);
+  font-weight: var(--font-weight-bold);
   padding-bottom: var(--space-half);
   cursor: default;
 }
@@ -128,6 +127,7 @@ textarea.Field--has-error:focus,
 
 .Field__required-text::before {
   content: ' ';
+  color: var(--text-color-base);
 }
 
 .Field__label--has-error .Field__required-text {

diff --git a/yarn.lock b/yarn.lock
@@ -5804,6 +5804,11 @@ follow-redirects@^1.0.0:
   resolved "https://registry.yarnpkg.com/follow-redirects/-/follow-redirects-1.13.0.tgz#b42e8d93a2a7eea5ed88633676d6597bc8e384db"
   integrity sha512-aq6gF1BEKje4a9i9+5jimNFIpq4Q1WiwBToeRK5NvZBd/TRsmW8BsJfOEGkr76TbOyPVD3OVDN910EcUNtRYEA==
 
+fontsource-roboto@^3.0.3:
+  version "3.0.3"
+  resolved "https://registry.yarnpkg.com/fontsource-roboto/-/fontsource-roboto-3.0.3.tgz#99c312babeabce22b3e933b3edf2951d4508f4f7"
+  integrity sha512-kfsC9qAP6XhwnSDAhg2lhWeaUJfLGXZh7GcLxFiz/4lXdkV2pVhWv2Xp9ES3b3BHdc9UuPrWXXLOphzHIStcOw==
+
 for-in@^1.0.1, for-in@^1.0.2:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/for-in/-/for-in-1.0.2.tgz#81068d295a8142ec0ac726c6e2200c30fb6d5e80"