fix(react): fix tooltip performance issue (#505)

dequelabs · Jan 12, 2022 · 4fc5b1a · 4fc5b1a
1 parent 46e5429
commit 4fc5b1a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/react/src/components/Tooltip/index.tsx b/packages/react/src/components/Tooltip/index.tsx
@@ -143,10 +143,10 @@ export default function Tooltip({
     return () => {
       targetElement.removeEventListener('keyup', handleEscape);
     };
-  }, [show]);
+  }, [showProp]);
 
   useEffect(() => {
-    if (typeof show !== undefined) {
+    if (typeof showProp !== undefined) {
       targetElement?.addEventListener('mouseenter', handleTriggerMouseEnter);
       targetElement?.addEventListener('mouseleave', handleTriggerMouseLeave);
       targetElement?.addEventListener('focusin', show);
@@ -158,7 +158,7 @@ export default function Tooltip({
       targetElement?.removeEventListener('focusin', show);
       targetElement?.removeEventListener('focusout', hide);
     };
-  }, [targetElement, show]);
+  }, [targetElement, showProp]);
 
   useEffect(() => {
     if (tooltipElement) {