Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ› Fix: ๋ฐฐํฌ env ๋ฐฑ์—”๋“œ API ์ˆ˜์ • #91

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

jangwonyoon
Copy link
Collaborator

@jangwonyoon jangwonyoon commented Mar 20, 2025

Summary by CodeRabbit

  • Chores
    • ์„œ๋น„์Šค์™€์˜ ์—ฐ๊ฒฐ ์„ค์ •์„ ์—…๋ฐ์ดํŠธํ•˜์—ฌ, ๋ชจ๋“  ํ™˜๊ฒฝ์—์„œ ์ผ๊ด€๋œ ์—”๋“œํฌ์ธํŠธ๋ฅผ ์‚ฌ์šฉํ•˜๋„๋ก ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.
    • ์ด ๋ณ€๊ฒฝ ์‚ฌํ•ญ์€ ์‹œ์Šคํ…œ์˜ ์ „๋ฐ˜์ ์ธ ์•ˆ์ •์„ฑ๊ณผ ์š”์ฒญ ๋ผ์šฐํŒ…์˜ ์ผ๊ด€์„ฑ์„ ํ–ฅ์ƒ์‹œ์ผœ ์‚ฌ์šฉ์ž ๊ฒฝํ—˜์— ๊ธ์ •์ ์ธ ์˜ํ–ฅ์„ ๋ฏธ์นฉ๋‹ˆ๋‹ค.

Copy link

coderabbitai bot commented Mar 20, 2025

Caution

Review failed

The pull request is closed.

๐Ÿ“ Walkthrough

Walkthrough

์ด PR์€ src/shared/constants/index.ts ํŒŒ์ผ ๋‚ด ์ƒ์ˆ˜ ํ• ๋‹น ๋กœ์ง์„ ์ˆ˜์ •ํ•ฉ๋‹ˆ๋‹ค. ์กฐ๊ฑด๋ฌธ์—์„œ NEXT_PUBLIC_STAGE๊ฐ€ 'production'์ผ ๊ฒฝ์šฐ ๊ธฐ์กด์— ์ƒ์‚ฐ์šฉ URL(https://api.somewhere, https://backend.somewhere) ๋Œ€์‹  ๊ฐœ๋ฐœ์šฉ URL(https://api-dev.even-took.com)์„ ๋ฐ˜ํ™˜ํ•˜๋„๋ก ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ๋ชจ๋“  ํ™˜๊ฒฝ์—์„œ ๋‘ ์ƒ์ˆ˜๋Š” ๋™์ผํ•œ ๊ฐœ๋ฐœ URL์„ ์‚ฌ์šฉํ•˜๊ฒŒ ๋˜๋ฉฐ, fallback URL์€ ์œ ์ง€๋ฉ๋‹ˆ๋‹ค.

Changes

ํŒŒ์ผ ๋ณ€๊ฒฝ ๋‚ด์šฉ
src/shared/constants/index.ts CLIENT_SIDE_URL์™€ SERVER_SIDE_URL์˜ production ํ™˜๊ฒฝ ์กฐ๊ฑด์ผ ๋•Œ ๋ฐ˜ํ™˜๋˜๋Š” URL์ด ๊ธฐ์กด์˜ ์ƒ์‚ฐ์šฉ URL์—์„œ ๊ฐœ๋ฐœ์šฉ URL(https://api-dev.even-took.com)๋กœ ๋ณ€๊ฒฝ๋จ.

๐Ÿ“œ Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 77e91fb and 316d760.

๐Ÿ“’ Files selected for processing (1)
  • src/shared/constants/index.ts (1 hunks)
โœจ Finishing Touches
  • ๐Ÿ“ Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share
๐Ÿชง Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jangwonyoon jangwonyoon marked this pull request as ready for review March 20, 2025 06:17
@jangwonyoon jangwonyoon added the auto approve PR์— ๋Œ€ํ•œ Auto Approve์ž…๋‹ˆ๋‹ค. label Mar 20, 2025
Copy link
Collaborator

@evenway2025 evenway2025 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ œ ๊ธฐ์ค€์—์„œ ์ด ์ฝ”๋“œ๋Š” ์ด๋ธํ•˜๊ฒŒ ์ž˜ ์ž‘์„ฑ๋œ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค. ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค. Approve ๋“œ๋ฆฌ๊ฒ ์Šต๋‹ˆ๋‹ค. ๐ŸŽŠ

@jangwonyoon jangwonyoon merged commit bf579f5 into develop Mar 20, 2025
7 of 8 checks passed
@jangwonyoon jangwonyoon deleted the fix/env branch March 20, 2025 06:18
semnil5202 added a commit that referenced this pull request Mar 23, 2025
* ๐Ÿ› Fix: ๋ฐฐํฌ env ๋ฐฑ์—”๋“œ API ์ˆ˜์ • (#91)

* [Feat] ๊ณตํ†ต ์ปดํฌ๋„ŒํŠธ Appbar, Toast ํŽธ์ง‘ (#93)

* โœจ Feat: Appbar ์ผ€์ด์Šค ์ถ”๊ฐ€(๋ฐ›์€ ๋ช…ํ•จ ํŽ˜์ด์ง€, ์„ค์ • ํŽ˜์ด์ง€)

* โœจ Feat: Toast ์ƒˆ ์ผ€์ด์Šค ์ถ”๊ฐ€(success)

* ๐Ÿ› Fix: onRightClickSecond potential issue ํ•ด๊ฒฐ

* feat: ์„ค์ • list view๋ฅผ ๊ตฌํ˜„ํ•ฉ๋‹ˆ๋‹ค. (#95)

* โ™ป๏ธ Refactor: ์‚ฌ์šฉํ•˜์ง€ ์•Š๋Š” ํƒ€์ž… ์ œ๊ฑฐ

* โ™ป๏ธ Refactor: ๋ฆฌ์ŠคํŠธ item ์„ค์ • ํŽ˜์ด์ง€ variant ํ™•์žฅ

* โœจ Feat: ์„ค์ • ๋ฆฌ์ŠคํŠธ view ๊ตฌํ˜„ (#97)

* [feat] ๊ณตํ†ต ์ปดํฌ๋„ŒํŠธ ๋ชจ๋‹ฌ ๊ตฌํ˜„ (#98)

* โœจ Feat: ๊ฐ„๊ฒฉ lx 28px ํ™•์žฅ

* ๐Ÿ“ฆ๏ธ Chore: dialog ํŒจํ‚ค์ง€ ์„ค์น˜

* ๐Ÿ’„ Style: radius 20px ์ถ”๊ฐ€

* ๐Ÿ’„ Style: border, spacing 28px, 20px ์ถ”๊ฐ€

* โœจ Feat: ๋ชจ๋‹ฌ ์ปดํฌ๋„ŒํŠธ ๊ตฌํ˜„, ์ปค์Šคํ…€ ๋ชจ๋‹ฌ ๊ตฌํ˜„

* โœจ Feat: ๊ณตํ†ต ์ปดํฌ๋„ŒํŠธ ๋ฒ„ํŠผ - dialog ๋ฒ„ํŠผ ์˜ต์…˜ ์ถ”๊ฐ€

* โœจ Feat: ์„ธํŒ… ๋‹ค์ด์–ผ๋กœ๊ทธ ์ถ”๊ฐ€

* โœจ Feat: ๊ณตํ†ต ๋ชจ๋‹ฌ, ํ”„๋กœ๊ทธ๋ž˜๋ฐ์‹ ๋‹ซ๊ธฐ ์ง€์›

example์— ์ง€์› ์„ค๋ช…

* [feat]: ํšŒ์› ํƒˆํ‡ด ํŽ˜์ด์ง€ UI ๊ตฌํ˜„, react hook form ๊ตฌํ˜„ (#103)

* feat: ํšŒ์› ํƒˆํ‡ด ์Šคํ‚ค๋งˆ ๊ตฌํ˜„

* โœจ Feat: ๊ณตํ†ต ์ฒดํฌ๋ฐ•์Šค ๋ฒ„ํŠผ, ์ฒดํฌ๋ฐ•์Šค ๋ฒ„ํŠผ ๊ทธ๋ฃน ๊ตฌํ˜„

* โœจ Feat: ๊ณตํ†ต fixedBottom ๋ฒ„ํŠผ ๊ตฌํ˜„

* โœจ Feat: ํšŒ์›ํƒˆํ‡ด react hook form ์ ์šฉ, ui ๊ตฌํ˜„ ์™„๋ฃŒ

* โœจ Feat: ํšŒ์›ํƒˆํ‡ด router ์ถ”๊ฐ€

* โ™ป๏ธ Refactor: ์นด๋“œ์„ธํŒ…๋ทฐ ; ์ถ”๊ฐ€

* โœจ Feat: ํšŒ์›ํƒˆํ‡ด ์ง์ ‘์ž…๋ ฅ ํ•„๋“œ isDirty๋กœ validation

ํ•„๋“œ๊ฐ€ ๋™์ž‘์„ ํ•˜๊ณ  ๋‚˜์„œ validation ์ถ”๊ฐ€

* โ™ป๏ธ Refactor: ๊ฐ€๋…์„ฑ ๊ฐœ์„ , config ๋ถ„๋ฆฌ

* โœจ Feat: ์•Œ๋žŒ ์„ค์ • UI ๊ตฌํ˜„ (#105)

* [feat] ๋ฐ›์€ ๋ช…ํ•จ ์ƒ์„ธ ํŽ˜์ด์ง€ ๋””์ž์ธ ๊ตฌํ˜„ (#100)

* โ™ป๏ธ refactor : next.config ์ด๋ฏธ์ง€ ๊ฒฝ๋กœ ์ถ”๊ฐ€

* โœจfeat : ์ˆ˜์ • , ์‚ญ์ œ svg ์ถ”๊ฐ€

* โ™ป๏ธ refactor : ๋กœ๊ทธ์ธ ํ›„ ๊ฒฝ๋กœ ๋กœ์ง ์ˆ˜์ •

* โ™ป๏ธ refactor : ์นด๋“œ ์ƒ์„ธ ํŽ˜์ด์ง€ ๋†’์ด ์ˆ˜์ •

* โœจfeat : ๋ช…ํ•จ ์ƒ์„ธ ์‘๋‹ต ๋ฐ์ดํ„ฐ ์ž„์‹œ ๋ณ€๊ฒฝ

* โœจfeat : ๋ฐ”ํ…€ ์‹œํŠธ ์ƒํƒœ ๊ด€๋ฆฌ ํ›… ์ƒ์„ฑ

* โœจfeat : ๋ฐ›์€ ๋ช…ํ•จ ๋ฐ์ดํ„ฐ ์ž„์‹œ ์ƒ์„ฑ

* โœจfeat : ๋ฐ›์€ ๋ช…ํ•จ ํƒ€์ž„ ์ž„์‹œ ์ž‘์„ฑ

* โ™ป๏ธ refactor : ๋‚ด ๋ช…ํ•จ ์ƒ์„ธ ํƒ€์ž… ํŒŒ์ผ๋ช… ์ˆ˜์ •

* โœจfeat : ๋ฐ›์€ ๋ช…ํ•จ ํƒ€์ž… ์ž„์‹œ ์ž‘์„ฑ

* โœจfeat : ๋ช…์ƒ ์ƒ์„ธ ํ—ค๋” ์ปดํฌ๋„ŒํŠธ ํ•œ์ค„ ๋ฉ”๋ชจ ๊ธฐ๋Šฅ ์ถ”๊ฐ€

* โ™ป๏ธ refactor : ๋ช…ํ•จ ์ƒ์„ธ ํŽ˜์ด์ง€ ๋ถˆํ•„์š”ํ•œ import ์ œ๊ฑฐ

* โ™ป๏ธ refactor : ๋ช…ํ•จ ์ƒ์„ธ ํ”„๋กœ์ ํŠธ ์ปดํฌ๋„ŒํŠธ ๋งํฌ ํƒœ๊ทธ ์ถ”๊ฐ€

* โœจfeat : ๋ฐ”ํ…€ ์‹œํŠธ ๊ณตํ†ต ์ปดํฌ๋„ŒํŠธ ์ƒ์„ฑ

* โ™ป๏ธ refactor : toast ์œ„์น˜ ์ˆ˜์ •

* โ™ป๏ธ refactor : ๋ณ€์ˆ˜ ์ฃผ์„ ์ถ”๊ฐ€

* โ™ป๏ธ refactor : ๋ถˆํ•„์š”ํ•œ ํƒ€์ž… ์ œ๊ฑฐ ๋ฐ ์˜ˆ์™ธ ์ฒ˜๋ฆฌ ์ถ”๊ฐ€

* โ™ป๏ธ refactor :  ํ† ์ŠคํŠธ ์ค‘๋ณต ํ˜ธ์ถœ ์ œ๊ฑฐ

* โœจfeat : appbar onLeftClick ๊ธฐ๋Šฅ ์ถ”๊ฐ€

* โ™ป๏ธ refactor : memoInput์œผ๋กœ ๋„ค์ด๋ฐ ์ˆ˜์ • , z-index ์ˆ˜์ •

* โ™ป๏ธ refactor :  BottomMenuItem์— className ์†์„ฑ ์ถ”๊ฐ€

* [Feat] ๋ช…ํ•จ ์ƒ์„ฑ - ๋ฉ”์ธํ™”๋ฉด UI ๊ตฌํ˜„ (#109)

* ๐Ÿ“ฆ๏ธ Chore: install tailwind-scrollbar-hide

* โœจ Feat: ๋ช…ํ•จ ์ƒ์„ฑ - ๋ฉ”์ธํ™”๋ฉด UI ๊ตฌํ˜„ (ํฅ๋ฏธ๋กœ์šด ๋ช…ํ•จ ์นด๋“œ ์ œ์™ธ)

* ๐Ÿ’„ Style: Appbar title text color ์ถ”๊ฐ€, Thumbnail์— imageurl ์ถ”๊ฐ€

* โ™ป๏ธ Refactor: ๋ช…ํ•จ ์ƒ์„ธ๋ทฐ ๋ถ„๋ฆฌ

* โœจ Feat: useReceivedCardQuery ๊ตฌํ˜„ ๋ฐ Card previewInfoType์˜ type ์ˆ˜์ •

* ๐Ÿ› Fix: fix pnpm error

* [Feat] Apple login ๊ตฌํ˜„ (#110)

* refactor: apple login key ์ˆ˜์ •

* refactor: apple login ๊ตฌํ˜„

* [Feat] Onboarding ํŽ˜์ด์ง€ UI ์ˆ˜์ • ๋ฐ ์ด๋ฏธ์ง€ ๊ต์ฒด (#99)

* refactor: home swiper classname ์ง€์ •

* refactor: onboarding image ์ฒซ ์Šฌ๋ผ์ด๋“œ ์™„์„ฑ

* refactor: ์Šฌ๋ผ์ด๋“œ ๋ฐ ๋””์Šคํฌ๋ฆฝ์…˜ ๊ตฌํ˜„

* refactor: second slide ๊ตฌํ˜„

* feat: ์„ธ๋ฒˆ์งธ ์Šฌ๋ผ์ด๋“œ ์ƒ์„ฑ

* refactor: ์‚ฌ์šฉํ•˜์ง€ ์•Š๋Š” ์ปดํฌ๋„ŒํŠธ ์ œ๊ฑฐ ๋ฐ ์˜จ๋ณด๋”ฉ ํŽ˜์ด์ง€ ๋ผ์šฐํŒ… ๋ถ„๋ฆฌ ๋Œ€๊ธฐ

* refactor: ์ž„์‹œ ์Šฌ๋ผ์ด๋“œ index ์ˆ˜์ •

* refactor: ์˜จ๋ณด๋”ฉ์ด๋ž‘ ๋กœ๊ทธ์ธ ํ”ผ์ณ ๋ถ„๋ฆฌ

* style: ์ฃผ์„ ์ถ”๊ฐ€

---------

Co-authored-by: ์œค์žฅ์› <[email protected]>
Co-authored-by: ์˜์ฃผ <[email protected]>
Co-authored-by: JaeIn1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto approve PR์— ๋Œ€ํ•œ Auto Approve์ž…๋‹ˆ๋‹ค.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants