Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Josh styleguide #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Josh styleguide #54

wants to merge 2 commits into from

Conversation

jshores
Copy link

@jshores jshores commented May 17, 2016

No description provided.

h2,
h3,
h4,
h5,
h6 {
margin: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Margins and paddings don't need to be repeated since they'll cascade from the initial rule.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand what you are saying, but what would be the correct syntax in this example?

Copy link
Contributor

@scurker scurker May 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h1-h6 have the same base margins, so you would want to cascade your changes in rules below the shared rule:

h1,
h2,
h3,
h4,
h5,
h6 {
  margin: 0;
  padding: 0;
  font-weight: 400;
}

h1 {
  font-weight: 700;
}

h5 {
  font-weight: normal;
  text-transform: uppercase;
}

@scurker
Copy link
Contributor

scurker commented May 17, 2016

This is a good start. Didn't you also have some documentation about the different headers, when and how they're used? I think that would be useful to include as part of the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants