Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated classes #704

Merged
merged 4 commits into from
Mar 15, 2022

Conversation

mukundansundar
Copy link
Contributor

@mukundansundar mukundansundar commented Mar 15, 2022

Signed-off-by: Mukundan Sundararajan [email protected]

Description

Removed classes deprecated in 1.3.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #601

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: Mukundan Sundararajan <[email protected]>
@mukundansundar mukundansundar marked this pull request as ready for review March 15, 2022 06:46
@mukundansundar mukundansundar requested review from a team as code owners March 15, 2022 06:46
@mukundansundar
Copy link
Contributor Author

supersedes #607 ....

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #704 (444e61b) into master (904dbe0) will increase coverage by 3.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #704      +/-   ##
============================================
+ Coverage     77.62%   80.66%   +3.04%     
  Complexity      993      993              
============================================
  Files            91       81      -10     
  Lines          3128     3010     -118     
  Branches        342      340       -2     
============================================
  Hits           2428     2428              
+ Misses          534      416     -118     
  Partials        166      166              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 904dbe0...444e61b. Read the comment docs.

Copy link
Contributor

@tanvigour tanvigour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artursouza artursouza merged commit 0b881d3 into dapr:master Mar 15, 2022
@mukundansundar mukundansundar deleted the remove-deprecated-classes branch March 15, 2022 18:19
DeepanshuA pushed a commit to DeepanshuA/java-sdk that referenced this pull request Mar 16, 2022
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <[email protected]>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <[email protected]>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <[email protected]>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 17, 2022
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <[email protected]>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <[email protected]>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: zjx244729 <[email protected]>
subash89 pushed a commit to subash89/java-sdk that referenced this pull request Mar 18, 2022
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <[email protected]>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <[email protected]>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: Subash Gamage <[email protected]>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <[email protected]>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <[email protected]>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: zjx244729 <[email protected]>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <[email protected]>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <[email protected]>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: zjx244729 <[email protected]>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <[email protected]>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <[email protected]>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: zjx244729 <[email protected]>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <[email protected]>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <[email protected]>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: zjx244729 <[email protected]>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <[email protected]>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <[email protected]>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: zjx244729 <[email protected]>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <[email protected]>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <[email protected]>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: zjx244729 <[email protected]>
artursouza pushed a commit to pkedy/java-sdk that referenced this pull request Jun 22, 2022
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <[email protected]>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <[email protected]>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
artursouza pushed a commit to pkedy/java-sdk that referenced this pull request Jun 22, 2022
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <[email protected]>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <[email protected]>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
artursouza added a commit that referenced this pull request Jun 23, 2022
* Adding pubsub routing support

Signed-off-by: Artur Souza <[email protected]>

* remove deprecated classes (#704)

* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <[email protected]>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <[email protected]>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: Artur Souza <[email protected]>

* Address PR comments.

Signed-off-by: Artur Souza <[email protected]>

Co-authored-by: Mukundan Sundararajan <[email protected]>
Co-authored-by: Artur Souza <[email protected]>
naah69 pushed a commit to naah69/dapr-java-sdk that referenced this pull request Jul 7, 2022
* Adding pubsub routing support

Signed-off-by: Artur Souza <[email protected]>

* remove deprecated classes (dapr#704)

* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <[email protected]>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <[email protected]>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: Artur Souza <[email protected]>

* Address PR comments.

Signed-off-by: Artur Souza <[email protected]>

Co-authored-by: Mukundan Sundararajan <[email protected]>
Co-authored-by: Artur Souza <[email protected]>
Signed-off-by: naah69 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated builder classes
3 participants