CORE-2017: added support for specified start dates #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmcorvidae
reviewed
Feb 6, 2025
internal/db/subscriptions.go
Outdated
| Where("users.username=?", username). | ||
| Where( | ||
| db.Where("? BETWEEN subscriptions.effective_start_date AND subscriptions.effective_end_date", date). | ||
| Or("? > subscriptions.effective_start_date AND subscriptions.effecrtive_end_date IS NULL"), |
There was a problem hiding this comment.
effecrtive is a typo here, I suspect
There was a problem hiding this comment.
Ah, yes, that is a typo. Thanks for catching that.
internal/db/subscriptions.go
Outdated
| @@ -265,8 +301,8 @@ func ListSubscriptions(ctx context.Context, db *gorm.DB, params *SubscriptionLis | |||
| // GetActiveSubscriptionDetails retrieves the user plan information that is currently active for the user. The effective | |||
| // start date must be before the current date and the effective end date must either be null or after the current date. | |||
| // If multiple active user plans exist, the one with the most recent effective start date is used. If no active user | |||
| // plans exist for the user then a new one for the basic plan is created. This funciton is like GetActiveSubscription except | |||
| // that it also loads all of the user plan details from the database. | |||
| // plans exist for the user then a new one for the basic plan is created. This funciton is like GetActiveSubscription | |||
There was a problem hiding this comment.
unimportant but: funciton
|
Thanks for the reviews! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this change is to enable subscription renewals. The basic use case is that the user has a subscription that lasts until a specific date and wants to extend the subscription. This will be done by creating a new subscription with its effective date set to the time when the current subscription ends. Since this is a generalized feature, we need to address cases where subscriptions overlap.