Fixed styles on Consensus management page #9178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9178 +/- ##
========================================
Coverage 73.34% 73.34%
========================================
Files 449 449
Lines 45863 45868 +5
Branches 3915 3917 +2
========================================
+ Hits 33637 33641 +4
- Misses 12226 12227 +1
🚀 New features to boost your workflow:
|
bsekachev
reviewed
Mar 10, 2025
cvat-ui/src/base.scss
Outdated
Comment on lines
98
to
109
| .cvat-control-inner { | ||
| min-height: inherit; | ||
| display: flex; | ||
| flex-direction: column; | ||
| background: white; | ||
| border-radius: $grid-unit-size; | ||
|
|
||
| @media screen and (min-width: $scroll-breakpoint) { | ||
| height: 100%; | ||
| min-height: auto; | ||
| } | ||
| } |
There was a problem hiding this comment.
-
Not really sure about names
cvat-control-*. The name is not associated to pages where it is used in my mind. What do you think aboutpage-header,page-tabs,page-inner? Maybe it is getting to abstract and need to think some more.. -
Try to use mixins. It looks they do exactly what you want: https://sass-lang.com/documentation/at-rules/mixin/
There was a problem hiding this comment.
What do you think about cvat-management-page-... type of naming? page.. feels really too abstract, it can be any page. Like we curretly have quality management, analytics management, consensus management.
|
6 tasks
|
@bsekachev applied |
bsekachev
approved these changes
Mar 12, 2025
archibald1418
pushed a commit
that referenced
this pull request
Mar 12, 2025
archibald1418
pushed a commit
that referenced
this pull request
Mar 12, 2025
archibald1418
added a commit
that referenced
this pull request
Mar 14, 2025
#### Depends on #9178 ### Motivation and context Test coverage for merging feature in consensus jobs (#8953) Commits were cherry-picked from #9190 ### How has this been tested? ### Case 1: check new merge buttons exist and are visible. New freshly created jobs have status 'new'. Trying to merge new jobs should result in error notifications and a HTTP 400 status code. All notifications are closed before the next testcase ### Case 2: Check consensus management page Consensus management page has settings for consensus quorum and minimum annotation overlap. Check that the page has fields for both options. If a field is filled incorrectly the form turns red and a message appears under the form. Trying to save options with erroneous forms should do nothing - no requests are sent, no errors shown. ### Case 3: Create annotations and check that job replicas merge correctly Create annotations with one rectangle in job replicas. The rectangle is moved with a step in each job's first frame. This means that after merging, the consensus job will have a rectangle which has to fully match a rectangle inside the replica in the middle. - Create annotations. - Merge consensus jobs. No errors should appear. A notification message validates the merge, close it - Go inside consensus job, remember the rectangle's positions - Go back to the task page using browser's 'Back' button - After loading the task page, consensus job's status should read **competed** - Open the middle job replica. Rectangle should be identical to the previous one ### Checklist - [ ] I submit my changes into the `develop` branch - [ ] I have created a changelog fragment - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) ### License - [ ] I submit _my code changes_ under the same [MIT License]( https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. --------- Co-authored-by: Oleg Valiulin <[email protected]> Co-authored-by: Kirill Lakhov <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
The PR fixes broken styles on consensus management page:
Also I extracted
-controlstyles tobase.scssso the header and inner styles can be re-used on different pages: consensus, quality for tasks and projects, analyticsAnd added notification error for quality/consensus settings (previously no notification was shown)
How has this been tested?
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)License
Feel free to contact the maintainers if that's a concern.