Added ability to customize logo and title #9052
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9052 +/- ##
===========================================
+ Coverage 73.91% 73.98% +0.06%
===========================================
Files 428 429 +1
Lines 44530 44601 +71
Branches 3881 3890 +9
===========================================
+ Hits 32916 32998 +82
+ Misses 11614 11603 -11
|
That seems normal to me - where else would it be? I'm assuming that the customization process will involve mounting an alternate icon file into the container. Did you have something else in mind? |
|
From my perspective, the logo customization process should be straightforward: place the new file in correct folder and configure a setting for its name if necessary. The same goes for text info in |
| .cvat-signing-header { | ||
| background: transparent; | ||
| position: fixed; | ||
| padding: $grid-unit-size * 2 0 0 0; | ||
| width: 100%; | ||
|
|
||
| .cvat-logo-icon { | ||
| fill: white; | ||
| filter: brightness(0) invert(1); |
There was a problem hiding this comment.
As I understand it makes any logo on sign-in page white, however what if a color logo provided?
This approach will break such logo.
|
Motivation and context
This simple PR moves logo management to
/aboutserver endpoint. It would make easier to change it if needed by replacinglogo.svgasset on the server. Additinally, there is a possibility to edit subtitle using settingsCVAT logo is
64x32px in svg format. It is reccomended to use the same format and proportions.Customization process is the following: update
logo.svgasset incvat/apps/engine/static(if the logo has different name, updateLOGO_FILENAMEinsettings/base.py), updatesubtitleinABOUT_INFOto change text on the sign-in/sign-up pages.How has this been tested?
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)License
Feel free to contact the maintainers if that's a concern.