Prevent extra tab from adding in history #9039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
The patch doesnt really work. Assuming I've added one more tab in analytics, I can not switch to it. It automatically goes back to first one: |
|
Ah, I see the issue. I will fix it. |
|
Any updates on this? |
|
Made some changes and tested whether the issue you mentioned above still exists or not. I have fixed it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9039 +/- ##
===========================================
+ Coverage 74.13% 74.15% +0.01%
===========================================
Files 428 428
Lines 44976 44976
Branches 3917 3917
===========================================
+ Hits 33345 33350 +5
+ Misses 11631 11626 -5
🚀 New features to boost your workflow:
|
|
klakhov
approved these changes
Mar 19, 2025
|
Looking forward to contributing more !! |
|
@ritikraj26 , great to know! Just select any issues on GitHub which you like and ping us. We will advise. |
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
This PR fixes an issue where navigating to task analytics caused
#overviewto be appended to the URL, requiring two back button presses to return to the previous page.The fix ensures that the hash change does not create a new history entry, fixing navigation.
How has this been tested?
Checklist
developbranch- [ ] I have updated the documentation accordingly- [ ] I have added tests to cover my changesLicense
Feel free to contact the maintainers if that's a concern.