generated from ctc-uci/npo-template-merged
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
86 edit invoice pdf page #98
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
7 tasks
jessieh9
requested changes
Mar 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @antsuh1028 @brelieu05, really good job on such a big task, just a couple small fixes.
- Didn't mention this earlier, caught it just now, but would you guys mind changing /savededits with /savededits/:id so that you don't need to query it in the component - also keeps it consistent with all the other endpoints
- Could be code that you two didn't write, but a refactor that can help is lines 40 - 57 and lines 113 - 130 create a
getGeneratedDate
function. Code is very similar and can be combined into one using parameters. If you could combine it so that we have less duplicate code, it'd be good. - On the Edit Invoice page, it seems that when I try to change the number for the comments, it doesn't change, it keeps reverting back to the original 751.00 number. The same issue occurs for totals in the summary table.

- Can we make the Sessions table scrollable within itself? Currently, the table streches all the way to show all comments. Let's cut off at a reasonable point and make the table itself scrollable, so our user doesn't need to scroll infinitely to get to the bottom of the page.
Other than that, thanks for all the hard work you two put into this, it was a large task and quite difficult. Good job.
…s tables scrollable
Co-authored-by: Anthony Suh <[email protected]>
jessieh9
previously approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots/Media
Edit Invoice
Saved Invoice