Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

86 edit invoice pdf page #98

Merged
merged 19 commits into from
Mar 13, 2025
Merged

86 edit invoice pdf page #98

merged 19 commits into from
Mar 13, 2025

Conversation

brelieu05
Copy link
Contributor

@brelieu05 brelieu05 commented Mar 6, 2025

Description

  • Edited Invoice page
  • Displaying correct information for invoice
  • Allowed for edits corresponding to Figma
  • Saved Edits updates / added to DB
  • Saved routes to Saved Page
  • Saved Edits Page
  • Showed all comments and edits matching Figma

Screenshots/Media

Edit Invoice

Image Image Image Image Image

Saved Invoice

Image ## Issues Closes #86

@brelieu05 brelieu05 requested review from theNatePi and jessieh9 March 6, 2025 07:58
@brelieu05 brelieu05 linked an issue Mar 6, 2025 that may be closed by this pull request
7 tasks
Copy link
Collaborator

@jessieh9 jessieh9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @antsuh1028 @brelieu05, really good job on such a big task, just a couple small fixes.

  • Didn't mention this earlier, caught it just now, but would you guys mind changing /savededits with /savededits/:id so that you don't need to query it in the component - also keeps it consistent with all the other endpoints
  • Could be code that you two didn't write, but a refactor that can help is lines 40 - 57 and lines 113 - 130 create a getGeneratedDate function. Code is very similar and can be combined into one using parameters. If you could combine it so that we have less duplicate code, it'd be good.
  • On the Edit Invoice page, it seems that when I try to change the number for the comments, it doesn't change, it keeps reverting back to the original 751.00 number. The same issue occurs for totals in the summary table.
image
  • Can we make the Sessions table scrollable within itself? Currently, the table streches all the way to show all comments. Let's cut off at a reasonable point and make the table itself scrollable, so our user doesn't need to scroll infinitely to get to the bottom of the page.

Other than that, thanks for all the hard work you two put into this, it was a large task and quite difficult. Good job.

jessieh9
jessieh9 previously approved these changes Mar 13, 2025
@jessieh9 jessieh9 merged commit 694a21e into main Mar 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit Invoice PDF Page
3 participants