Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

84 create new program page remake edit programs #97

Merged
merged 47 commits into from
Mar 11, 2025

Conversation

lanaramadan
Copy link
Contributor

@lanaramadan lanaramadan commented Mar 6, 2025

Description

  • Created ModifyProgram.jsx which conditonally renders the new AddProgram.jsx page or EditProgram.jsx
  • Matched Figma
  • Added edit functionality so that edits are reflected in the database.

Issues

Closes #84

lanaramadan and others added 30 commits February 25, 2025 13:36
Co-authored-by: Margaret Galvez <[email protected]>
@lanaramadan lanaramadan linked an issue Mar 6, 2025 that may be closed by this pull request
7 tasks
@theNatePi
Copy link
Collaborator

theNatePi commented Mar 7, 2025

Great work @lanaramadan @margoglvz, the page looks great! There are a number of (mostly style) changes we would like to be made:

  • When searching for Payers and Lead Artists, the dropdown menu should show over the page instead of pushing the page content down [1]
    • Make sure this dropdown is only visible when the user is clicked into the text edit bar
    • When a name is added, the text box should empty and the popover should be closed
    • When a name is selected in the dropdown:
      • Populate the text field with the name
      • Close the popover
      • Turn the "+" to purple as shown in Figma
      • Only add the name once they press the "+", of if they then hit enter
  • The program information at the bottom is optional. The page should allow for saving even when no information is provided
  • Recurring sessions do not work
    • "Every one week" should make a session for each day selected every single week
    • For the other options, feel free to leave them
  • When saying "2 week" or "n week", it should repeat at that interval. For example, repeat every 2 weeks would repeat those sessions every other week
  • Custom reoccurrence modal does not match design [2]
    • There are some differences in color, text content, text placement, etc.
  • For all dropdowns, use popovers to make the version in Figma. Don't use the built in version [3]
    • See the Figma as all of the dropdowns on this page should match design
  • The X for the name tags should turn purple on hover [4]
  • When pressing the X on the page itself, the discard modal is not shown [5]
  • The X button is not properly navigating back a page when creating a new program. When I click it, I always get redirected to
    http://localhost:3000/programs/%5Bobject%20Object%5D
    To test this, you can make a new button on playground which navigates to your /addprogram, then make sure you get back there when pressing X
  • When editing a program, the session time portion should be greyed out [6]
  • New sessions are not being created when editing a program
  • When editing a program, the dropdown should show "Reset all bookings" if no edits are made [7]
  • client/src/components/programs/programComponents/ReoccuranceModal.jsx seems to be an empty file

[1]
image

[2]

image image

image image

image image

[3]

image image

[4]
image

[5]
image

[6]

image image

[7]

image image

Great work so far on the page. Make sure to start these fixes early if possible, and let us know if you need any help or clarification!

Copy link
Collaborator

@theNatePi theNatePi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix needed

@lanaramadan lanaramadan requested a review from theNatePi March 10, 2025 11:53
@theNatePi theNatePi merged commit e659bc3 into main Mar 11, 2025
1 check passed
@theNatePi theNatePi deleted the 84-create-new-program-page-remake-edit-programs branch March 11, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create New Program page, Remake Edit Programs
3 participants