85 sorting tables edit invoicestotal #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e date still broken) and fixed invoice/total endpoint
Co-Authored-By: Sindhuja Gorti <[email protected]>
Co-Authored-By: Sindhuja Gorti <[email protected]>
6 tasks
jessieh9
requested changes
Mar 6, 2025
There was a problem hiding this comment.
Hi @colet0227 @sindhujagorti, nice work on the tasks so far, just a couple fixes here.
- Could you move the filters into
/lpa/client/src/components/filters/? It was specified in the issue and it seems to have been misplaced in programs. This makes it easier for future developers to use the component and works well for organization purposes. - Small fix for the sorting modal icon, can you make it bit smaller to match design? Hint: You can look into width and height attributes
Other than that, good work. Thanks.
jessieh9
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated invoices/total/:id endpoint and added sorted functionality
Screenshots/Media
Issues
Closes #85