Invoice Dashboard Improvement #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Daiki Narimoto <[email protected]>
4 tasks
jessieh9
requested changes
Mar 6, 2025
There was a problem hiding this comment.
Hi @HazelYuAhiru @dnarimot , great work so far. Just a couple small fixes
- For the table Headers
<Th></Th>, can we try get this to match the figma in camel case and not all caps. Chakra UI by default keeps it all caps, but there is an attributetextTransform="none"that can prevent that. You might need to tweak font size a little bit - Same small fix for the "Past Due", "Not Paid" tags, change them from all caps to match design's camelcase
For a larger fix not previously mentioned,
-
I noticed that the invoices repeat themselves if they have different payers.
- For example, the program, Testing class, with deadline 12/31/2024 appears twice on invoice page.
- A program has invoice for each month and I believe what's happening is because they have multiple payers, it appears more than once.
-
The fix is to combine the returned elements if they have multiple payers. So the program, Testing program, with deadline in 12/31/2024 appearing twice would be combined; similar for the one with deadline in 02/20/2025
If you need extra time to implement this fix, feel free to let me know. Thanks.
jessieh9
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved the Invoice Dashboard that shows all the invoices to match the new design.
Screenshots
Issues
Closes #87