Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

67 implement notifications and email system #83

Merged
merged 7 commits into from
Feb 23, 2025

Conversation

AstonKiChan
Copy link
Contributor

Description

Implements notification page to show warnings about invoices and button to send emails with PDFs.

Screenshots/Media

Issues

Closes #67

@theNatePi
Copy link
Collaborator

theNatePi commented Feb 21, 2025

Hey @Xire7 @AstonKiChan, good work! Just a couple of things are needed:

  • For the nodemailer, please extend the .env.example file to include your new variables
    • For example if you added process.env.PROD_EMAIL_FIRSTNAME, make sure to add PROD_EMAIL_FIRSTNAME to the .env.example file in /server
    • In this example env, don't put any sensitive information, but feel free to put non sensitive information. For example, you may unclude the email first/last name, but exclude the email and password (EMAIL_VAR=<email here>)
  • Send Nate your actual edited .env file (so we can give it to everyone to use next sprint)
  • Remove /lpa/package-lock.json
    • I think this file was automatically created by npm

@theNatePi
Copy link
Collaborator

Looks good to me!

@theNatePi theNatePi dismissed their stale review February 23, 2025 21:04

Change completed

@theNatePi theNatePi merged commit 0edd9f1 into main Feb 23, 2025
1 check passed
@theNatePi theNatePi deleted the 67-implement-notifications-and-email-system branch February 23, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement notifications and email system
3 participants