Created total endpoint and settings skeleton #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
jessieh9
requested changes
Feb 21, 2025
There was a problem hiding this comment.
Hey @brelieu05 @colet0227, awesome work on the total endpoint, it was really complicated but you guys got it!! Settings page looks great! Just a small fixes
- line 344 eventID is queried from invoices table but previously you already got the invoice so wouldn't you be able to just do invoice.eventID to prevent another call to DB
- line 377 they round it to 2 decimal places, but I think what we should do is remove the round and make it be the actual number and on the frontend we can round it or cut it off later for accuracy (same for line 392 and 402)
Other than that, really good work, thanks!
jessieh9
approved these changes
Feb 23, 2025
There was a problem hiding this comment.
@brelieu05 @colet0227 Looks good to me, one small issue was that when you were fixing the cost to make it unrounded, you forgot to return bookingCost within bookingCosts so some endpoints returned "null". I fixed it for you guys since it was a quick fix but good work! Keep in mind these small changes next time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots/Media
Issues
Closes #