Edit program page & Navbar #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h from whole clients list used to be just clients for this event
…fixed; save button navigates back now and all buttons should work
… the components for the figma icons
|
Note: Fix yarn + npm conflict on merge |
jessieh9
requested changes
Feb 7, 2025
There was a problem hiding this comment.
Hi guys, just a couple changes here:
- Do not use npm for your packages. You will need to remove package-lock.json and reinstall all your packages using yarn. Here is a code snippet of how to revert to yarn
git checkout origin/main -- package-lock.json yarn.lock
rm package-lock.json
rm -rf node_modules
yarn install
git add package.json yarn.lock
git commit -m "Restore yarn.lock and remove package-lock.json"
After doing this, all the packages you installed using NPM will be gone. You will need to re-install those packages for the site to work.
- For the navbar component, if I scroll down, it seems that it doesn't stretch all the way down to the page.
- Also, a small fix we can try to make is font weight of the Links in the navbar to match design more (try 500 or so)
- For the Close button, let's try to get the popup closer into the page so it doesn't trail off, matching the Figma
- Small fix is to remove variables, imports, and things not being used
Other than that, great work on the modals, it was a large amount of data and the functionality is great.
|
Yarn lock still showing npm, is this an issue @jessieh9? |
|
Some outstanding issues, but overall looks good to me! Nice work |
jessieh9
previously approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Create Edit Program page and edit Navbar
Screenshots/Media
Issues
Closes #58