-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create invoice page #64
Conversation
…omponent and comments to table.
…opposed to doing it in events.js via eventsRouter.get(/remaining/:id).
949914d
to
f725ddf
Compare
One thing we weren't confident with is the "Remaining Balance" section. Since it depends on the total and paid values of each invoice we had 3 options:
We went with the third option, but let us know if we should change anything (and how). |
f725ddf
to
224ad62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work guys! Some edits:
- Some invoices show no data, such as invoice with ID = 4
- The "Program:" title at the top seems to be showing the description of the program, when it should show the name of the program
- The "Billed To" Section should only show the payees, not the instructor
- I think you left some console.log's in there, make sure to remove them
- In the invoice page, you call await backend.get("invoices/" + id); twice. Make sure to only do this once and to re-use the first content
- It seems that the indent spacing in events.js (the router) went from 2 spaces to 4. Make sure all tab spacing is 2 spaces
- The invoices router might also have some new indent spacing issues, make sure it is also consistant
Don't worry about changing the remaining balance implementation you have
Important
Make sure to pull before making modifications
Reminder: These fixes are due Tmr at midnight
Very good work on the table, it works really well!
@lanaramadan @AstonKiChan
Was because all the fields would be set to null if smth was missing (ie. payees)
f61697f
to
8174eff
Compare
Was returning an error if there was no payees
8174eff
to
57c8cb3
Compare
my bad, accidentally changed the label thinking it was my PR |
LGTM! |
Description
Created InvoiceTitle, InvoiceStats (which includes payees), InvoicePayments components for the single Invoice page. Also added pagination.
Screenshots/Media
Issues
Closes #53