-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to https://github.com/coq/coq/pull/20036 #456
Conversation
I think the picks tested in CI in the coq-ci branch should be adjusted. The only relevant pick in this branch is this: https://github.com/coq/platform/blob/coq-ci/package_picks/package-pick-ci.sh Can you please add this and remove all other picks in the CI YAML files for the coq-ci branch? Feel free to remove all other picks from the coq-ci branch. This is also the pick in which coqide needs to be adjusted - it isn't. Sorry for the mess - I hacked this branch together in a bit of a hurry. If you prefer, I can also do the changes on your PR. |
Done
Not sure what you're expecting here. In Coq CI, things are configured to use the rocqide.opam file in Coq's repo.
No worries. Just to be clear, my most pressing need is to fix Coq CI for windows that is currently broken (pretty bad with 9.0 release candidate expected next week). If CI remains broken here on this coq-ci branch, it's probably no big deal for now. |
Since we need this to fix Coq CI, let's merge. We can still refine it later. |
Doesn't seem to have been enough:
|
The icon files still exist under EDIT: I opened coq/coq#20059. |
Let's see what happens following: #457 |
I meant that you need to rename the opam package name in the coq-ci.sh file - it is meanwhile, but it wasn't the case when I wrote my comment. Please feel free to merge to the coq-ci branch as needed - this is the reason why it exists. |
Adapt to coq/coq#20036
@MSoegtropIMC the coqide package has been renamed rocqide by above mentionned PR, I hope this can fix Windows CI on Coq master.