-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue and pull request templates: should we have them? #80
Comments
I feel it's a bit early for pull request templates, I think they can be a great help to help maintain a project, but cause friction for contributors, especially if they are not a good fit. If you would like to try, I'd start with something very minimal. |
Sure! How does this draft look/feel? ### What are you trying to accomplish?
### What approach did you choose and why?
### What should reviewers focus on? |
sounds like a great start 👍🏼 maybe we could add an HTML comment stating that these are just suggestions and contributors can change or remove headers if they don't fit their use case? |
### What are you trying to accomplish? Closes #80 ### What approach did you choose and why? I followed what was written in https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository and opted for the simplest route by adding the template to `.github/`. ### What should reviewers focus on? Correctness 😉
🎉 This issue has been resolved in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Straight from the docs:
I'm not sure if there's an existing canon we can pull from in this organization or in the
github
organization, but maybe something to consider for the future? 🤔The text was updated successfully, but these errors were encountered: