Skip to content

Commit

Permalink
Merge branch 'main' into 9-cache
Browse files Browse the repository at this point in the history
  • Loading branch information
francisfuzz authored Sep 16, 2024
2 parents 81a6f33 + 6a4b80a commit 7a740cc
Show file tree
Hide file tree
Showing 5 changed files with 4,149 additions and 3,567 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
node_modules
coverage
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ await prompt({
unit: { type: "string", enum: ["c", "f"] },
},
required: ["location", "unit"],
additionalProperties: False,
additionalProperties: false,
},
},
},
Expand Down Expand Up @@ -461,7 +461,7 @@ While implementing the lower-level functionality, we also dream big: what would
## Contributing
Please see [CONTRIBUTING.md](CONTRIBUTING.md)
Please see [CONTRIBUTING.md](CONTRIBUTING.md).
## License
Expand Down
4 changes: 2 additions & 2 deletions dreamcode.md
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ const { isValidRequest, payload } = await copilotAgent.verifyAndParse(

## Notes

Regarding the context passed to event handlers
Regarding the context passed to event handlers:

- `message` / `confirmation` / etc are objects as received by the user
- `octokit` is a pre-authenticated octokit instance
Expand All @@ -211,6 +211,6 @@ Regarding the context passed to event handlers
- `respond` is an API to send different types of responses to the user
- `log` is the logger as we use it in Octokit. See https://github.com/octokit/core.js?tab=readme-ov-file#logging

On how to receive the events (transport layer)
On how to receive the events (transport layer):

- `createNodeMiddleware` is something we have currently built into some of the Octokit SDKs, e.g. https://github.com/octokit/app.js?tab=readme-ov-file#createnodemiddlewareapp-options. However, I think we will move these out into separate packages, such as `@octokit/webhooks-middleware-node`, etc. But for now, we can just assume that we ship with it by default. We can also add other middlewares for Netlify/Vercel edge functions, lambda, etc.
Loading

0 comments on commit 7a740cc

Please sign in to comment.