Refactoring: PHP 7.1, Bootstrap3/4 Renderers #8
Conversation
f3l1x
changed the title
|
Thank you @mabar. Could you also update ruleset.xml to force tabs (https://github.com/contributte/console/blob/master/ruleset.xml#L16-L22). Thanks. |
|
CI is failing: https://travis-ci.org/contributte/forms/jobs/367030945 |
|
Hi @mabar Example: |
|
@f3l1x I am not sure why error log cannot be fetched, it worked at least before last commit (ruleset.xml) @aleswita I am not big fan of form renderers at all as they don't fit well in MVC architecture, but we can add addons support too. |
|
@mabar Please use latest ninjify/qa (you know) and finish this PR to be merged ;-) Thanks. |
ruleset.xml
Outdated
| <?xml version="1.0"?> | ||
| <ruleset name="Contributte"> | ||
| <!-- Extending rulesets --> | ||
| <rule ref="vendor/ninjify/coding-standard/ruleset.xml"/> |
There was a problem hiding this comment.
Use contributte.xml instead of ruleset.xml ;-) It force tabs.
| use Nette\Forms\Controls; | ||
| use Nette\Forms\Form; | ||
| use Nette\Forms\Rendering\DefaultFormRenderer; | ||
| use function mb_strpos; |
There was a problem hiding this comment.
Please, drop use functions. We've discussed it on Slack. You know.
|
Awesome, thanks. |
@f3l1x Code is ready for review.
Note to self: Documentation is needed.