Test containerd repo #673
Test containerd repo #673
Conversation
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
test-containerd-repo
branch
2 times, most recently
from
b407b74 to
be9fe91
Compare
hack/install/utils.sh
Outdated
| # BUILDTAGS are bulid tags for runc and containerd. | ||
| BUILDTAGS=${BUILDTAGS:-seccomp apparmor} | ||
|
|
||
| CONTAINERD_DIR=${DESTDIR}/usr/local |
There was a problem hiding this comment.
Suggest moving all these component specific DIR and PKG variable declarations over to the component install script just after they source this util script.
| TMPGOPATH=$(mktemp -d /tmp/cri-install-crictl.XXXX) | ||
| GOPATH=${TMPGOPATH} | ||
|
|
||
| #Install crictl |
There was a problem hiding this comment.
since we've split this into it's own install.. and moved the from-vendor calls to each separate install.. let's also go ahead and move the CRITOOL_ variable assignments from utils.sh to here...
There was a problem hiding this comment.
Actually CRITOOL_VERSION is also used in make test-cri. And I don't want to include critest in install-deps.sh for now, because that binary requires cri-tools repo to run test.
Although @feiskyer built everything into one binary recently kubernetes-sigs/cri-tools#261, it still doesn't support running test in parallel.
I think after single binary critest is fully done, we can build and install critest here. And remove the critest installation in make test-cri.
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
test-containerd-repo
branch
from
be9fe91 to
a69f355
Compare
This PR:
make sync-vendorto sync vendors with containerd.install-deps.shintoinstall-cni.sh,install-crictl.sh,install-runc.shandinstall-containerd.sh.test/build-containerd. It usesinstall-containerd.shto build containerd binaries from existing containerd repo (test-infra will checkout containerd repo for containerd repo CI) into release tarball for test.In this way, we can build CI test for containerd repo.