Get spec from metadata #102
Conversation
hack/versions
Outdated
| @@ -1,4 +1,4 @@ | |||
| RUNC_VERSION=639454475cb9c8b861cc599f8bcd5c8c790ae402 | |||
| CNI_VERSION=v0.4.0 | |||
| CONTAINERD_VERSION=8ed1e24ae925b5c6d8195858ee89dddb0507d65f | |||
| CRITEST_VERSION=v0.1 | |||
| CRITEST_VERSION=dbfd7f14a457fc95cf736c5361b244c087cc9688 | |||
hack/versions
Outdated
| @@ -1,4 +1,4 @@ | |||
| RUNC_VERSION=639454475cb9c8b861cc599f8bcd5c8c790ae402 | |||
| CNI_VERSION=v0.4.0 | |||
| CONTAINERD_VERSION=8ed1e24ae925b5c6d8195858ee89dddb0507d65f | |||
| CRITEST_VERSION=v0.1 | |||
| CRITEST_VERSION=dbfd7f14a457fc95cf736c5361b244c087cc9688 | |||
There was a problem hiding this comment.
Ah the merged commit is .. 74bbd4e142f752f13c648d9dde23defed3e472a2
| @@ -55,6 +56,22 @@ func (c *criContainerdService) ExecSync(ctx context.Context, r *runtime.ExecSync | |||
| return nil, fmt.Errorf("container %q is in %s state", id, criContainerStateToString(meta.State())) | |||
| } | |||
|
|
|||
| // Get exec process spec. | |||
There was a problem hiding this comment.
above comment // Get container config from container store .. should be changed to // Get metadata for container from our container store .. or something like that
There was a problem hiding this comment.
I don't quite get it.
There was a problem hiding this comment.
see the comment above for call to get metadata for the container from the container metadata store
| // Get exec process spec. | ||
| cntrResp, err := c.containerService.Get(ctx, &containers.GetContainerRequest{ID: id}) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to get container %q from containerd: %v", id, err) |
There was a problem hiding this comment.
failed to get container struct.. or container information..
There was a problem hiding this comment.
The interface is called containers.Get and GetContainerRequest. :p
There was a problem hiding this comment.
right, just trying to be more specific in the error message.. get container doesn't say much. The response includes the container struct that has the spec in it. Was thinking more detail might help down the road.
There was a problem hiding this comment.
iow what's the difference between failing to get the container when pulling an image vs failing to get the container here?
There was a problem hiding this comment.
ah well the line number is enough.. either way is ok by me 👍
Random-Liu
force-pushed
the
get-spec-from-metadata
branch
from
f12a4bc to
69f7c52
Compare
Signed-off-by: Random-Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
get-spec-from-metadata
branch
from
69f7c52 to
d8ce670
Compare
Get spec from metadata
Remove spec from our metadata and get spec from containerd container metadata.
This PR also updated cri validation test version to include kubernetes-sigs/cri-tools#115.