Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract all adapters #3

Merged
merged 11 commits into from
Sep 9, 2024
Merged

Extract all adapters #3

merged 11 commits into from
Sep 9, 2024

Conversation

chakra-guy
Copy link
Collaborator

No description provided.

chakra-guy and others added 9 commits September 4, 2024 10:22
Co-Authored-By: Edouard Bougon <[email protected]>
Co-Authored-By: Edouard Bougon <[email protected]>
Co-Authored-By: Edouard Bougon <[email protected]>
Co-Authored-By: Edouard Bougon <[email protected]>
Co-Authored-By: Edouard Bougon <[email protected]>
Co-Authored-By: Edouard Bougon <[email protected]>
@chakra-guy chakra-guy changed the title Extract more adapters Extract all adapters Sep 5, 2024
Copy link
Collaborator

@EdouardBougon EdouardBougon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Nice improvement with testUtils

},
};

export function createRPCClient(chain: domain.Chain = domain.Chain.Ethereum): viem.PublicClient {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chakra-guy chakra-guy merged commit 7bbfd4a into main Sep 9, 2024
1 check passed
@chakra-guy chakra-guy deleted the extract-more-adapters branch September 9, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants