⚡️ Speed up _import_anyscale()
by 1,835,645% in libs/langchain/langchain/llms/__init__.py
#42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
_import_anyscale()
inlibs/langchain/langchain/llms/__init__.py
📈 Performance went up by
1,835,645%
(18,356.45x
faster)⏱️ Runtime went down from
33043.40μs
to1.80μs
Explanation and details
(click to show)
Given that the function is only importing a module and returning a class from it, there is not much to optimize here. But, the efficiency can be enhanced by importing the module at the top level of the script, not inside a function. When Python imports a module, it first checks the module registry (sys.modules) to see if the module is already imported. If that's the case, Python uses that existing object from cache. But the lookup for the module in sys.modules still takes time. Therefore, if we import the module at the top level, it will be somewhat quicker because imports won't be checked every time the function is called.
Here,
Anyscale
is imported asanyscale_module
at global level. Then, the updated function_import_anyscale
returnsanyscale_module
without repeatedly performing import operation.Correctness verification
The new optimized code was tested for correctness. The results are listed below.
✅ 0 Passed − ⚙️ Existing Unit Tests
✅ 0 Passed − 🎨 Inspired Regression Tests
✅ 2 Passed − 🌀 Generated Regression Tests
(click to show generated tests)