⚡️ Speed up validate_prompt_input_variables()
by 5% in libs/langchain/langchain/memory/summary.py
#37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
validate_prompt_input_variables()
inlibs/langchain/langchain/memory/summary.py
📈 Performance went up by
5%
(0.05x
faster)⏱️ Runtime went down from
10.20μs
to9.70μs
Explanation and details
(click to show)
The current code appears to be pythonically correct and quite optimal function-wise. However, the exception case can be slightly rewritten by avoiding string formatting and possibly improve the function readability.
In this alternative, the f-string is replaced by the list version and then using the ''.join() operation which tends to be faster. We also replaced the direct dictionary access with the 'get' method to avoid 'KeyError' in case the "prompt" key is not in the values dictionary. The performance improvements are minor but they slightly enhance the robustness of your code.
Correctness verification
The new optimized code was tested for correctness. The results are listed below.
✅ 0 Passed − ⚙️ Existing Unit Tests
✅ 0 Passed − 🎨 Inspired Regression Tests
✅ 12 Passed − 🌀 Generated Regression Tests
(click to show generated tests)