⚡️ Speed up get_default_document_variable_name()
by 21% in libs/langchain/langchain/chains/combine_documents/refine.py
#32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
get_default_document_variable_name()
inlibs/langchain/langchain/chains/combine_documents/refine.py
📈 Performance went up by
21%
(0.21x
faster)⏱️ Runtime went down from
7.50μs
to6.20μs
Explanation and details
(click to show)
The provided code could be optimized by eliminating the redundant assignment of
llm_chain_variables
in bothif
andelse
condition. Instead, assign it before checking the conditions. Here's the optimized version.This minor optimization helps to eliminate the redundant step of calculating
llm_chain_variables
twice, whendocument_variable_name
is present invalues
. This can help speed up the execution a bit, especially if accessingvalues["initial_llm_chain"].prompt.input_variables
is computationally expensive.Correctness verification
The new optimized code was tested for correctness. The results are listed below.
✅ 0 Passed − ⚙️ Existing Unit Tests
✅ 0 Passed − 🎨 Inspired Regression Tests
✅ 10 Passed − 🌀 Generated Regression Tests
(click to show generated tests)