⚡️ Speed up _run_llm_or_chain()
by 35% in libs/langchain/langchain/smith/evaluation/runner_utils.py
#28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
_run_llm_or_chain()
inlibs/langchain/langchain/smith/evaluation/runner_utils.py
📈 Performance went up by
35%
(0.35x
faster)⏱️ Runtime went down from
105.60μs
to78.10μs
Explanation and details
(click to show)
Optimizing this code won't significantly affect its run-time performance considering the type of operations involved few tips to improve would include reducing the usage of isinstance-checks and handling the use of defaults for Optional parameters efficiently. We can also take advantage of Exception chaining and use a unified RunnableConfig to avoid code repetitions.
This new implementation explicitly handles defaults for Optional parameters and also reduces some of the redundant code in the _run_llm and _run_chain functions.
Correctness verification
The new optimized code was tested for correctness. The results are listed below.
✅ 0 Passed − ⚙️ Existing Unit Tests
✅ 0 Passed − 🎨 Inspired Regression Tests
✅ 2 Passed − 🌀 Generated Regression Tests
(click to show generated tests)